Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional error handling to CosmosHealthCheck #4781

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Add additional error handling to CosmosHealthCheck #4781

merged 8 commits into from
Jan 28, 2025

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Jan 15, 2025 •
edited by azure-boards bot
Loading

Description

  • Adds Cosmos 503 exception to retriable exceptions in CosmosHealthCheck.
  • Adds additional diagnostic logging when Cosmos 503 exception is encounters.
  • Also catches Cosmos timeout exceptions and returns a degraded health status

Related issues

AB#137391

Testing

Unit testing.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner January 15, 2025 20:08
@mikaelweave mikaelweave added this to the 2Wk07 milestone Jan 15, 2025
@mikaelweave mikaelweave added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Jan 15, 2025
@mikaelweave mikaelweave changed the title Personal/mikaelw/cosmos healthcheck additional checks Add additional error handling to CosmosHealthCheck Jan 15, 2025
@mikaelweave mikaelweave added Bug Bug bug bug. and removed Bug Bug bug bug. labels Jan 15, 2025
LTA-Thinking
LTA-Thinking previously approved these changes Jan 17, 2025
View reviewed changes
fhibf
fhibf previously approved these changes Jan 17, 2025
View reviewed changes
@mikaelweave mikaelweave dismissed stale reviews from fhibf and LTA-Thinking via 7653e90 January 17, 2025 22:53
@mikaelweave
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fhibf fhibf merged commit 0932788 into main Jan 28, 2025
47 checks passed
@fhibf fhibf deleted the personal/mikaelw/cosmos-healthcheck-additional-checks branch January 28, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajithaalurims rajithaalurims rajithaalurims approved these changes

@fhibf fhibf fhibf left review comments

@LTA-Thinking LTA-Thinking LTA-Thinking left review comments

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Bug Bug bug bug.
Projects
None yet
Milestone
2Wk07
Development

Successfully merging this pull request may close these issues.
4 participants
@mikaelweave @fhibf @LTA-Thinking @rajithaalurims